fix(release): follow the attestation bundle rename in the repo-owned asset check and SECURITY.md - #76
Merged
Merged
Conversation
…asset check and SECURITY.md The template sync in #74 renamed the release attestation bundle the managed publish stage attaches from attestation.jsonl to attestation.json. The repo-owned pre-publish asset check still ignored only the old name, so a rerun after the publish stage had attached the new bundle would count it as an unexpected third asset and stop the pipeline; SECURITY.md still told readers to verify against the old asset name. The check now ignores both names: the managed cleanup deletes only the current one, so a draft a pre-rename attempt left an attestation.jsonl on keeps it. SECURITY.md and the workflow's comments name the new asset.
There was a problem hiding this comment.
🟡 Changes recommended
The workflow must remove the legacy bundle and exclude only the current bundle from validation.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates release validation and security guidance for the renamed attestation bundle.
Changes:
- Documents
attestation.jsonas the current bundle. - Adjusts release asset validation for current and legacy bundle names.
File summaries
| File | Description |
|---|---|
SECURITY.md |
Updates bundle verification guidance. |
.github/workflows/update-release.yml |
Updates asset validation, but retaining the legacy bundle may publish stale provenance. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…d of ignoring it A leftover from a pre-rename attempt is stale provenance the managed publish stage no longer cleans up (it deletes only the current bundle name), so the repo-owned asset check deletes it before comparing and ignores only attestation.json.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
The template sync in #74 renamed the attestation bundle the managed publish stage attaches:
How
update-release.yml: the ignore list names both bundle names, with the reason beside it; comments follow the rename.SECURITY.md:gh attestation verify --bundlepoints atattestation.json.Raised by the Copilot review on #74. Its other note, the managed
release.ymldeleting only the current bundle name on reruns, belongs to Vivswan/repo-platform and is not touched here.Proof
git grep attestation.jsonlleaves only the deliberate legacy-name ignore.